Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143590823 I am new to git, not sure if I am reading the changes correctly. It looks you are undoing https://issues.apache.org/jira/browse/SPARK-9078 changes in your last merge. I see you fixed the current dialect implementation in the code to use the new method, but there can be custom dialect implementations using the old getJDBCType(dt: DataType) method. After this change , user specified existing custom dialects may not work. Example : import org.apache.spark.sql.jdbc._ JdbcDialects.registerDialect(MyNetEzzaDialect) Another minor thing, any particualar reason for setting java.sql.Types.CHAR insead of java.sql.Types.VARCHAR in the following statements. OracleDialect : Some(JdbcType(s"VARCHAR(${md.getLong("maxlength")})", java.sql.Types.CHAR)) NetEzzaDialect : Some(JdbcType("VARCHAR(255)", java.sql.Types.CHAR))
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org