Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String)
val yMean = ySummarizer.mean(0)
val yStd = math.sqrt(ySummarizer.variance(0))
--- End diff --
1) `instances` will be cached, but if we go the `normal` path, `instances`
will be never unpersisted.
2) Please move the if condition to the top, and if the solver is `auto`, we
just do a take(1) to get number of features so we don't run unnecessary `val
(featuresSummarizer, ySummarizer) `. This can solve 1) as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
