Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r40596818
--- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.crypto
+
+/**
+ * Defines properties of a CipherSuite. Modeled after the ciphers in
+ * {@link javax.crypto.Cipher}.
+ * @param name name of cipher suite, as in {@link javax.crypto.Cipher}
+ * @param algoBlockSize size of an algorithm block in bytes
+ */
+case class CipherSuite(name: String, algoBlockSize: Int) {
+ var unknownValue: Integer = null
+
+ def setUnknownValue(unknown: Integer) {
+ this.unknownValue = unknown
+ }
+
+ def getUnknownValue(): Integer = unknownValue
+
+
+ override def toString(): String = {
+ var builder: StringBuilder = new StringBuilder("{")
+ builder.append("name: " + name)
+ builder.append(", algorithmBlockSize: " + algoBlockSize)
+ if (unknownValue != null) {
+ builder.append(", unknownValue: " + unknownValue)
+ }
+ builder.append("}")
+ builder.toString()
+ }
+
+ /**
+ * Returns suffix of cipher suite configuration.
+ * @return String configuration suffix
+ */
+ def getConfigSuffix(): String = {
+ val parts = name.split("/")
+ var suffix: StringBuilder = new StringBuilder()
+ parts.foreach(part =>
+ suffix.append(".").append(part.toLowerCase())
+ )
+ suffix.toString()
+ }
+}
+
+
+object UNKNOWN extends CipherSuite("Unknown", 0)
+
+object AES_CTR_NOPADDING extends CipherSuite("AES/CTR/NoPadding", 16)
+
+object CipherSuite {
+ /**
+ * Convert to CipherSuite from name, {@link #algoBlockSize} is fixed for
+ * certain cipher suite, just need to compare the name.
+ * @param name cipher suite name
+ * @return CipherSuite cipher suite
+ */
+ def convert(name: String): CipherSuite = {
+ if (name.equals(AES_CTR_NOPADDING.name)) {
--- End diff --
use `name match { ... }` instead of cascading ifs. Also, if you call this
method `apply`, you can just say `CipherSuite("foo")` instead of
`CipherSuite.convert("foo")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
