Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-143862548 Hi @winningsix, I started to review this but the style violations are too distracting; I suggest fixing all those up front before going through a more complete review. If in doubt, refer to: https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org