Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8867#discussion_r40705866
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorDelegationTokenUpdater.scala
 ---
    @@ -76,7 +76,10 @@ private[spark] class ExecutorDelegationTokenUpdater(
             SparkHadoopUtil.get.getTimeFromNowToRenewal(
               sparkConf, 0.8, 
UserGroupInformation.getCurrentUser.getCredentials)
           if (timeFromNowToRenewal <= 0) {
    -        executorUpdaterRunnable.run()
    +        // If the `timeFromNowToRenewal` equals 0, it's better to wait 1 
minutes to schedule for
    +        // avoid cycle calling and cause StackOverflow Exception.
    --- End diff --
    
    We end up scheduling the next run of the `executorUpdaterRunnable` from 
within this class. If the executor renewal interval is set to 0, we end up 
calling it again from within the same thread (indefinitely). But I am not sure 
why it would be 0 here though (since this is started only if the login is from 
keytab). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to