Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144619340
Hi sun-rui,
I'll do the correction with param. I'm not sure what do you mean with
coding style issues for dontrun {}.
I did it exactly as arrange and added examples for sort. Is the issue with
decreasing=TRUE. ???
What don't you exactly like in the function name ?
1. We are trying to support R function namings. Similarly, as merge and
join are synonyms.
2. I'm not overwriting anything.
3. in arrange you allow the users to do the ordering embracement manually
and in sort, we do automatically. What do you mean with combining ? do you want
to add another decreasing argument in arrange ? If yes then we might need to
think about cases like asc(asc(col)) cols ???
I personally think that it makes sense to keep it separately as is. But if
you can exactly tell me what the problem is, I might be able to understand and
work on it.
Thanks,
Narine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
