Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8950#discussion_r41128898
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala ---
    @@ -265,16 +323,20 @@ private[ui] class BatchPage(parent: StreamingTab) 
extends WebUIPage("batch") {
        * Generate the job table for the batch.
        */
       private def generateJobTable(batchUIData: BatchUIData): Seq[Node] = {
    -    val outputOpIdToSparkJobIds = 
batchUIData.outputOpIdSparkJobIdPairs.groupBy(_.outputOpId).toSeq.
    -      sortBy(_._1). // sorted by OutputOpId
    +    val outputOpIdToSparkJobIds = 
batchUIData.outputOpIdSparkJobIdPairs.groupBy(_.outputOpId).
           map { case (outputOpId, outputOpIdAndSparkJobIds) =>
             // sort SparkJobIds for each OutputOpId
             (outputOpId, outputOpIdAndSparkJobIds.map(_.sparkJobId).sorted)
           }
    +    val outputOps = (0 until batchUIData.numOutputOp).map { outputOpId =>
    +      val status = batchUIData.failureReason.getOrElse(outputOpId, 
"Succeeded")
    --- End diff --
    
    > In fact, there should be "Failed" and "Failed due to Spark job error". In 
the first case, the output op error will be below the "Failed" .
    
    I think now we cannot distinguish these two errors. They are both caught in 
`org.apache.spark.streaming.scheduler.Job.run`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to