GitHub user rick-ibm opened a pull request:
https://github.com/apache/spark/pull/8982
[SPARK-10855] [SQL] Add a JDBC dialect for Apache Derby
@marmbrus
@rxin
This patch adds a JdbcDialect class, which customizes the datatype mappings
for Derby backends. The patch also adds unit tests for the new dialect,
corresponding to the existing tests for other JDBC dialects.
JDBCSuite runs cleanly for me with this patch. So does JDBCWriteSuite,
although it produces noise as described here:
https://issues.apache.org/jira/browse/SPARK-10890
This patch is my original work, which I license to the ASF. I am a Derby
contributor, so my ICLA is on file under SVN id "rhillegas":
http://people.apache.org/committer-index.html
Touches the following files:
---------------------------------
org.apache.spark.sql.jdbc.JdbcDialects
Adds a DerbyDialect.
---------------------------------
org.apache.spark.sql.jdbc.JDBCSuite
Adds unit tests for the new DerbyDialect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rick-ibm/spark b_10855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8982
----
commit cf51be37e41097c8342bc94c174bc767ca9ee567
Author: Rick Hillegas <rhil...@us.ibm.com>
Date: 2015-09-30T22:32:14Z
SPARK-10855: Add a JDBC dialect for Apache Derby. Add unit tests for the
new dialect.
commit 21decab9d8aa98364d7d6aa7c71e2082b4cd7d69
Author: Rick Hillegas <rhil...@us.ibm.com>
Date: 2015-10-02T21:14:46Z
SPARK-10855: Fix DECIMAL mapping for Derby JdbcDialect so that Spark can
create Derby tables with DECIMAL columns.
commit ffb3fdef9f914ecef9333d727a9667511d994907
Author: Rick Hillegas <rhil...@us.ibm.com>
Date: 2015-10-02T22:36:48Z
SPARK-10855: For Derby JDBC dialect, only change the precision/scale of a
DECIMAL if the max Derby precision is exceeded.
commit 11fdb0411c2413e8f13530960684a7023236b23d
Author: Rick Hillegas <rhil...@us.ibm.com>
Date: 2015-10-05T16:15:13Z
SPARK-10855: Correct an overly long line.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
