Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8934#discussion_r41172960
--- Diff: python/pyspark/sql/types.py ---
@@ -1209,6 +1219,12 @@ def __new__(self, *args, **kwargs):
else:
raise ValueError("No args or kwargs")
+ def __init__(self, *args, **kwargs):
+ if hasattr(self, "__fields__") and "count" in self.__fields__:
--- End diff --
Should we check all the names of method? `self.__fields__` is an list, the
`in` could be expensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
