Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8931#discussion_r41426589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -69,6 +72,9 @@ case class TungstenAggregate(
protected override def doExecute(): RDD[InternalRow] = attachTree(this,
"execute") {
val numInputRows = longMetric("numInputRows")
val numOutputRows = longMetric("numOutputRows")
+ val totalPeakMemory = longMetric("totalPeakMemory")
--- End diff --
Also it's weird to say "total" in some places but not in others. For
instance, records in and out are also totals, but it doesn't say "total" in
those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
