Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8990#discussion_r41426940
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala ---
@@ -354,6 +354,28 @@ private[hive] class ClientWrapper(
qlTable
}
+ override def createView(view: HiveTable): Unit = withHiveState {
+ // TODO: this is duplicated with `toQlTable` except the table type
stuff.
+ val tbl = new metadata.Table(view.database, view.name)
+ tbl.setTableType(HTableType.VIRTUAL_VIEW)
+ tbl.setSerializationLib(null)
+ tbl.clearSerDeInfo()
+
+ // We will save the same SQL string to original and expanded text,
which is different from Hive.
+ tbl.setViewOriginalText(view.viewText.get)
+ tbl.setViewExpandedText(view.viewText.get)
--- End diff --
Perhaps leave a TODO here so readers know this is not ideal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
