Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8909#discussion_r41429939
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -264,12 +262,16 @@ private[hive] object HiveQl extends Logging {
        * Returns the HiveConf
        */
       private[this] def hiveConf: HiveConf = {
    -    val ss = SessionState.get() // SessionState is lazy initialization, it 
can be null here
    +    var ss = SessionState.get()
    +    // SessionState is lazy initialization, it can be null here
         if (ss == null) {
    -      new HiveConf()
    -    } else {
    -      ss.getConf
    +      val original = Thread.currentThread().getContextClassLoader
    +      val conf = new HiveConf(classOf[SessionState])
    +      conf.setClassLoader(original)
    +      ss = new SessionState(conf)
    +      SessionState.start(ss)
    --- End diff --
    
    `SessionState.start` will change the context classloader to the classloader 
associated with `conf`. Is it the expected behavior?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to