Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8083#discussion_r41442238
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
 ---
    @@ -194,6 +194,17 @@ case class UnknownPartitioning(numPartitions: Int) 
extends Partitioning {
       override def guarantees(other: Partitioning): Boolean = false
     }
     
    +case class RandomPartitioning(numPartitions: Int) extends Partitioning {
    --- End diff --
    
    Actually, I change my mind: this is a fine name. The fact that we do the 
partitioning in a round-robin fashion is an implementation detail, not an 
inherent feature of the partitioning itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to