Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8931#discussion_r41468810
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -690,6 +697,9 @@ class TungstenAggregationIterator(
val mapMemory = hashMap.getPeakMemoryUsedBytes
val sorterMemory =
Option(externalSorter).map(_.getPeakMemoryUsedBytes).getOrElse(0L)
val peakMemory = Math.max(mapMemory, sorterMemory)
+ totalPeakMemory += peakMemory
+ maxPeakMemory += peakMemory
+ totalSpilledSize +=
TaskContext.get().taskMetrics().memoryBytesSpilled - spilledSizeBefore
--- End diff --
this seems fine, but I wonder what happens if you have multiple threads per
task, i.e. if another thread spills a lot of things in the mean time in a
different operator. Is that a potential problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
