Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9016#discussion_r41474659 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java --- @@ -65,6 +65,22 @@ public UnsafeArrayData valueArray() { } @Override + public int hashCode() { + int h = numElements; + return (h * 31 + keys.hashCode()) * 31 + values.hashCode(); + } + + @Override + public boolean equals(Object obj) { + if (obj instanceof UnsafeMapData) { + UnsafeMapData map = (UnsafeMapData) obj; + return numElements == map.numElements && keys.equals(map.keyArray()) + && values.equals(map.valueArray()); --- End diff -- how about elements orders? `Map(1 -> "a", 2 -> "b")` should be equal to `Map(2 -> "b", 1 -> "a")`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org