Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9021#issuecomment-146582988
LGTM.
@vanzin I think maybe we should monitor dual connections. I also found an
issue about the message order. If we run the following code in order,
```
ref.send("A")
ref.send("B")
```
the receiver side may see "B" before "A". It's because we use a thread pool
to call `sendRpc`. While you fix the transport library, is it possible to make
`clientFactory.createClient` non-blocking so that we don't need the thread pool?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
