Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8990#discussion_r41540255
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -77,6 +77,16 @@ private[hive] case class CreateTableAsSelect(
         childrenResolved
     }
     
    +private[hive] case class CreateViewAsSelect(
    +    tableDesc: HiveTable,
    +    child: LogicalPlan,
    +    allowExisting: Boolean,
    +    orReplace: Boolean,
    --- End diff --
    
    Maybe `overwrite` or `replace` is a better name? `orReplace` is too tightly 
coupled with the sql syntax.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to