Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8983#issuecomment-146631777
I only found one rule in `Optimizer` to optimize `In` to `InSet` when the
values in `list` are all literals.
I think it's better to add a case in `NullPropagation` to optimize `In`
with literal null `key` to literal null even the `list` are not all literals.
Anyway it should be another PR and this PR LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
