Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9017#discussion_r41544170
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -51,12 +51,12 @@ def _gen_param_header(name, doc, defaultValueStr):
"""
# a placeholder to make it appear in the generated doc
- $name = Param(Params._dummy(), "$name", "$doc")
+ $name = Param(Params._dummy(), "$name", "$doc.")
--- End diff --
I did it the other way since it would be less changes, but yah that sounds
like this would be more readable. I'll swap it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
