Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r41544610
--- Diff: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala
---
@@ -36,8 +43,15 @@ private[spark] trait ShuffleManager {
numMaps: Int,
dependency: ShuffleDependency[K, V, C]): ShuffleHandle
- /** Get a writer for a given partition. Called on executors by map
tasks. */
- def getWriter[K, V](handle: ShuffleHandle, mapId: Int, context:
TaskContext): ShuffleWriter[K, V]
+ /** Get a writer for a given partition. Called on executors by map tasks.
--- End diff --
super nit: comment should follow javadoc formatting:
/**
* Comment.
*/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
