Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9000#discussion_r41557901
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
    @@ -409,40 +397,42 @@ private[spark] class MemoryStore(blockManager: 
BlockManager, maxMemory: Long)
        * from the same RDD (which leads to a wasteful cyclic replacement 
pattern for RDDs that
        * don't fit into memory that we want to avoid).
        *
    -   * Assume that `accountingLock` is held by the caller to ensure only one 
thread is dropping
    --- End diff --
    
    Did you mean to omit this part of the comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to