Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r41581657
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.crypto
+
+import org.apache.hadoop.io.Text
+
+/**
+ * Constant variables
+ */
+object CommonConfigurationKeys {
+ val SPARK_SHUFFLE_TOKEN = new Text("SPARK_SHUFFLE_TOKEN")
+ val SPARK_SECURITY_CRYPTO_BUFFER_SIZE_DEFAULT = 8192
+ val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_DEFAULT = "AES/CTR/NoPadding"
+ val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_KEY =
"spark.security.crypto.cipher.suite"
+ val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX =
"spark.security.crypto.codec.classes"
+ val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY =
+ SPARK_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX +
AES_CTR_NOPADDING.getConfigSuffix()
+ val SPARK_SECURITY_JAVA_SECURE_RANDOM_ALGORITHM_KEY =
+ "spark.security.java.secure.random.algorithm"
+ val SPARK_SECURITY_JAVA_SECURE_RANDOM_ALGORITHM_DEFAULT = "SHA1PRNG"
+ val SPARK_SECURITY_SECURE_RANDOM_IMPL_KEY =
"spark.security.secure.random.impl"
+ val SPARK_ENCRYPTED_INTERMEDIATE_DATA_BUFFER_KB = "spark.job" +
+ ".encrypted-intermediate-data.buffer.kb"
+ val DEFAULT_SPARK_ENCRYPTED_INTERMEDIATE_DATA_BUFFER_KB = 128
+ val SPARK_SECURITY_SECURE_RANDOM_DEVICE_FILE_PATH_KEY =
"spark.security.random.device.file.path"
+ val SPARK_SECURITY_SECURE_RANDOM_DEVICE_FILE_PATH_DEFAULT =
"/dev/urandom"
+ val SPARK_ENCRYPTED_INTERMEDIATE_DATA =
"spark.job.encrypted-intermediate-data"
+ val DEFAULT_SPARK_ENCRYPTED_INTERMEDIATE_DATA = false
+ val SPARK_ENCRYPTED_INTERMEDIATE_DATA_KEY_SIZE_BITS =
+ "spark.job.encrypted-intermediate-data-key-size-bits"
+ val DEFAULT_SPARK_ENCRYPTED_INTERMEDIATE_DATA_KEY_SIZE_BITS = 128
+ val SPARK_SHUFFLE_KEYGEN_ALGORITHM = "spark.shuffle.keygen.algorithm"
+ val DEFAULT_SPARK_SHUFFLE_KEYGEN_ALGORITHM = "HmacSHA1"
+ val SHUFFLE_KEY_LENGTH = ""
+ val DEFAULT_SHUFFLE_KEY_LENGTH = 64
--- End diff --
Is there a reason why there are different key length defaults depending on
whether intermediate data encryption is enabled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
