Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8757#discussion_r41586259 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -352,6 +353,30 @@ class BlockMatrix @Since("1.3.0") ( } } + private type BlockDestinations = Map[(Int, Int), Set[Int]] + + /** + * Simulate the multiplication with just indices in order to cut costs on communication, when --- End diff -- "just indices" --> "just block indices" Document return value. Copy doc: ```The `colsPerBlock` of this matrix must equal the `rowsPerBlock` of `other`.```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org