Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9036#discussion_r41595658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -304,7 +304,10 @@ object HiveTypeCoercion {
}
/**
- * Convert all expressions in in() list to the left operator type
+ * Convert the value and in list expressions to the common operator type
+ * by looking at all the argument types and finding the closest one that
+ * all the arguments can be cast to. When no common operator type is
found
+ * an Analysis Exception is raised.
--- End diff --
@cloud-fan
You are right Wenchen.I just wanted to somehow mention that an exception
will be raised on a data type mistmatch. I will reword it to the way you
suggest. ""the original one will be returned and an Analysis Exception will be
raised at type checking phase". Let me push a commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
