Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41691353
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#' @param joinExpr (Optional) The expression used to perform the join.
joinExpr must be a
-#' Column expression. If joinExpr is omitted, join() wil perform a
Cartesian join
+#' Column expression. If joinExpr is omitted, join() will perform a
Cartesian join
#' @param joinType The type of join to perform. The following join types
are available:
-#' 'inner', 'outer', 'left_outer', 'right_outer', 'semijoin'. The default
joinType is "inner".
+#' 'inner', 'outer', 'full', 'fullouter', leftouter', 'left',
--- End diff --
yeah, API compatibility is a concern. So we can make R code consistent with
the scala version at
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala#L21
That is, replace the "_" char in the join type string with empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
