Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9023#discussion_r41692768
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1795,17 +1795,15 @@ setMethod("fillna",
if (length(colNames) == 0 || !all(colNames != "")) {
stop("value should be an a named list with each name being
a column name.")
}
-
- # Convert to the named list to an environment to be passed
to JVM
- valueMap <- new.env()
- for (col in colNames) {
- # Check each item in the named list is of valid type
- v <- value[[col]]
+ # Check each item in the named list is of valid type
+ lapply(value, function(v) {
--- End diff --
nit: this is going through it twice.. perhaps add a FUN param to
`convertNamedListToEnv` to allow for a custom validation for each value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
