Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/9054#issuecomment-147128825
  
    I think you're misunderstanding how it works. It doesn't create a thread, 
use it for one task, and then keep it alive for 60 seconds. Instead, any idle 
thread is reused immediately rather than creating a new one. It's only after a 
thread has seen no tasks for 60 seconds that it stops.
    
    I disagree that it "keeps more threads alive than necessary". Still, what's 
the problem you're solving? This also has nothing to do with how `ForkJoinPool` 
is better. I'm certain it is not appropriate for this case. Would you close 
this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to