GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/9066
[SPARK-11053] Remove use of KVIterator in SortBasedAggregationIterator SortBasedAggregationIterator uses a KVIterator interface in order to process input rows as key-value pairs, but this use of KVIterator is unnecessary, slightly complicates the code, and might hurt performance. This patch refactors this code to remove the use of this extra layer of iterator wrapping and simplifies other parts of the code in the process. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JoshRosen/spark sort-iterator-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9066.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9066 ---- commit 91c88ebaf888cf4ca1885af5fa18d2f1c8a4f926 Author: Josh Rosen <joshro...@databricks.com> Date: 2015-10-11T03:19:37Z Simplify wrapping of iterator into KVIterator. commit 2b8bf947b0434146131b3af4a314cc89ace8a874 Author: Josh Rosen <joshro...@databricks.com> Date: 2015-10-11T04:17:29Z Remove KVIterator from SortBasedAggregationIterator ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org