Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9066#discussion_r41714812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -101,18 +117,16 @@ class SortBasedAggregationIterator(
// The search will stop when we see the next group or there is no
// input row left in the iter.
- var hasNext = inputKVIterator.next()
- while (!findNextPartition && hasNext) {
+ while (!findNextPartition && inputIterator.hasNext) {
// Get the grouping key.
- val groupingKey = inputKVIterator.getKey
- val currentRow = inputKVIterator.getValue
+ val inputRow = inputIterator.next()
+ val groupingKey = groupingKeyProjection(inputRow).copy()
+ val currentRow = inputRow.copy()
--- End diff --
Maybe we can avoid of these two `copy`s?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
