Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/9059#discussion_r41831148
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -289,13 +290,15 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends WebUIPage("") {
val summary: NodeSeq =
<div>
<ul class="unstyled">
- {if (parent.sc.isDefined) {
- // Total duration is not meaningful unless the UI is live
- <li>
- <strong>Total Uptime: </strong>
- {UIUtils.formatDuration(System.currentTimeMillis() -
startTime)}
- </li>
- }}
+ <li>
+ <strong>Total Uptime:</strong>
+ {
+ if (endTime < 0) {
+ val endTime = System.currentTimeMillis();
+ }
+ UIUtils.formatDuration(endTime - startTime)
--- End diff --
I think, the inner `endTime` shouldn't be alive when we reach
`UIUtils.formatDuration` because of it's scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
