GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/9093
[SPARK-11080] Throw exception when NamedExpression.newExprId is called
inside tasks
My understanding of `NamedExpression.newExprId` is that it is only intended
to be called on the driver. If it is called on executors, then this may lead to
scenarios where the same expression id is re-used in two different
NamedExpressions.
More generally, I think that calling `NamedExpression.newExprId` within
tasks may be an indicator of potential attribute binding bugs. Therefore, I
think that we should throw an exception when this method is called inside of
tasks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark SPARK-11080
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9093
----
commit 48e3d1c8fe5e2a58114c225334eaa8affd2a2f45
Author: Josh Rosen <joshro...@databricks.com>
Date: 2015-10-13T07:37:21Z
Throw exception when NamedExpression.newExprId is called from task.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
