Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8453#discussion_r41909011
--- Diff:
sql/hive/src/test/java/org/apache/spark/sql/hive/JavaMetastoreDataSourcesSuite.java
---
@@ -71,7 +72,8 @@ public void setUp() throws IOException {
if (path.exists()) {
path.delete();
}
- hiveManagedPath = new
Path(sqlContext.catalog().hiveDefaultTableFilePath("javaSavedTable"));
+ hiveManagedPath = new
Path(sqlContext.catalog().hiveDefaultTableFilePath(
+ TableIdentifier.apply("javaSavedTable")));
--- End diff --
`new TableIdentifier` need to pass in a `Option`, which is hard for java.
Actually I think using `apply` is fine as a workaround for java, and we
have already done this before:
https://github.com/apache/spark/blob/master/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java#L148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
