Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9081#discussion_r41930462
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/MultiInstanceRelation.scala
---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.sql.catalyst.analysis
-
-import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
-
-/**
- * A trait that should be mixed into query operators where an single
instance might appear multiple
- * times in a logical query plan. It is invalid to have multiple copies
of the same attribute
- * produced by distinct operators in a query tree as this breaks the
guarantee that expression
- * ids, which are used to differentiate attributes, are unique.
- *
- * During analysis, operators that include this trait may be asked to
produce a new version
- * of itself with globally unique expression ids.
--- End diff --
In-fact much of this could probably be copied to NewOutput.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
