Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r42051371
--- Diff:
core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.crypto
+
+import org.apache.hadoop.io.Text
+
+/**
+ * Constant variables
+ */
+private[spark] object CommonConfigurationKeys {
+ val SPARK_SHUFFLE_TOKEN = new Text("SPARK_SHUFFLE_TOKEN")
+ val SPARK_SECURITY_CRYPTO_BUFFER_SIZE_DEFAULT = 8192
+ val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_DEFAULT = "AES/CTR/NoPadding"
+ val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_KEY =
"spark.security.crypto.cipher.suite"
+ val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX =
"spark.security.crypto.codec.classes"
+ val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY =
--- End diff --
I'm a little confused about these config options. Could you write
documentation for them in `configuration.md` or in this class's scaladoc?
This one `SPARK_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY`
particularly looks like a mouthful. If I understand correctly it would be
"spark.security.crypto.codec.classes.aes.ctr.nopadding".
My question is: how is this expected to be used?
From what I can understand, you have two configs: one to choose the cipher
suite, one to choose the codec. Why can't you have just two configs:
`spark.security.crypto.cipher.suite`
`spark.security.crypto.codec.classes`
And that's it? Why do you need the second one to have a separate, dynamic
config key depending on the chose cipher suite?
Also, minor, but I'd be explicit about these options being related to the
shuffle, so `spark.shuffle` instead of `spark.security`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
