Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/8880#issuecomment-148217525
  
    Hi @winningsix , I think this patch needs a lot of cleanup around the 
configuration part. It's really confusing at the moment, and among other issues 
it seems like there are duplicate, conflicting settings.
    
    The input stream implementation is also hard to follow, although I think I 
convinced myself it's doing the right thing. It would be nice to try to 
simplify it, so that others can more easily understand the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to