GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/9125

    [SPARK-11117] [SQL] Makes PhysicalRDD aware of whether underlying data 
source produces UnsafeRow

    This PR tries to address [this PR comment] [1]. Changes made here:
    
    1. Adds a new data source interface method `BaseRelation.outputsUnsafeRows`.
    1. Overrides `PhysicalRDD.outputsUnsafeRows` to avoid unnecessary 
`ConvertToUnsafe` operator
    1. Makes `ParquetRelation` always produce `UnsafeRow`s.
    
    In addition,  `BaseRelation.needsConversion` is deprecated by 
`BaseRelation.outputsInternalRow`. The reason is that I constantly find 
`needsConversion` confusing, and always need to double think what kind of 
conversion is actually needed.
    
    [1]: https://github.com/apache/spark/pull/9104#issuecomment-147872722

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark 
spark-11117.unsafe-physical-rdd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9125
    
----
commit 67cbc8e324633e9e80b8ee488160cffdc5374086
Author: Cheng Lian <l...@databricks.com>
Date:   2015-10-14T22:40:03Z

    Makes ParquetRelation produce UnsafeRows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to