GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/9126
[SPARK-11110] [Build] Remove transient annotation for parameters.
`@transient` annotations on class parameters (not case class parameters or
vals) causes compilation errors during compilation with Scala 2.11.
I understand that transient *parameters* make no sense, however I don't
quite understand why the 2.10 compiler accepted them.
Note: in case it is preferred to keep the annotations in case someone would
in the future want to redefine them as vals, it would also be possible to just
add `val` after the annotation, e.g. `class Foo(@transient x: Int)` becomes
`class Foo(@transient private val x: Int)`.
I chose to remove the annotation as it also reduces needles clutter,
however please feel free to tell me if you prefer the second option and I'll
update the PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jodersky/spark sbt-scala-2.11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9126
----
commit 98fb2431dae8c22ec418f0e4bbb6d90ea6b2e0bf
Author: Jakob Odersky <joder...@gmail.com>
Date: 2015-10-14T23:00:18Z
Remove transient annotation for parameters.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
