Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8652#discussion_r42079174
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -268,6 +268,12 @@ private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
     
       object CartesianProduct extends Strategy {
         def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
    +      case logical.Join(CanBroadcast(left), right, joinType, condition) =>
    +        execution.joins.BroadcastNestedLoopJoin(
    +          planLater(left), planLater(right), joins.BuildLeft, joinType, 
condition) :: Nil
    --- End diff --
    
    Also, the join type is CROSS_JOIN. At here we just put INNER as a 
placeholder because the type does not really matter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to