Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9130#discussion_r42088208 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2153,6 +2153,9 @@ private[spark] object Utils extends Logging { conf.getInt("spark.executor.instances", 0) == 0 } + def withResource[R <: Closeable, T](resource: R, f: () => T): T = { --- End diff -- It's probably best to do it like this ```scala def withResource[R <: Closeable, T](createResource: => R)(f: R => T): T = { } ``` then you can call it like ```scala withResource(factory.createParser(row)) { parser => ... } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org