Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8923#issuecomment-148445380
This looks good, but can you add a test case? Mostly I'd like to
understand the dependency structure that leads to this (perhaps there are other
corner cases related to it we should look at). I was expecting to see one
stage as a dependency for multiple later stages, or something like that, but I
don't see that even in your "After" image. A test case will also help prevent
future regressions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
