Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/8621#discussion_r42198441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -732,11 +732,12 @@ object SimplifyCasts extends Rule[LogicalPlan] {
}
/**
- * Removes [[UnaryPositive]] identify function
+ * Removes [[UnaryPositive]] identify function and [[PromotePrecision]]
wrapper.
--- End diff --
`Removes identify functions` ? Just in case we need to remove more
functions like these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
