Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9130#discussion_r42209376
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -251,16 +254,18 @@ case class GetJsonObject(json: Expression, path:
Expression)
// modified slightly if there is only a single element written
val buffer = new StringWriter()
val flattenGenerator = jsonFactory.createGenerator(buffer)
- flattenGenerator.writeStartArray()
var dirty = 0
- while (p.nextToken() != END_ARRAY) {
- // track the number of array elements and only emit an outer
array if
- // we've written more than one element, this matches Hive's
behavior
- dirty += (if (evaluatePath(p, flattenGenerator, nextStyle, xs))
1 else 0)
+ Utils.tryWithResource(jsonFactory.createGenerator(buffer)) {
flattenGenerator =>
--- End diff --
we should delete the outer flattenGenerator here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
