Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8969#issuecomment-149047792
This seems good overall, but one high-level question: why store `None` on
the Java side instead of `null`? I'm just wondering whether mapping it back to
Java `null` would make more sense. I guess it doesn't make a difference from
Python's point of view, since Python's view of the metadata is preserved
roundtrip, but it could hypothetically matter if Python is trying to set
metadata which is then consumed by Java library code (for example).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
