Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9099#discussion_r42339541
--- Diff: R/pkg/R/SQLContext.R ---
@@ -90,19 +90,18 @@ createDataFrame <- function(sqlContext, data, schema =
NULL, samplingRatio = 1.0
if (is.null(schema)) {
schema <- names(data)
}
- n <- nrow(data)
- m <- ncol(data)
- # get rid of factor type
- dropFactor <- function(x) {
+ # get rid of factor type and adjust for lists
+ cleanCols <- function(x) {
if (is.factor(x)) {
as.character(x)
+ } else if(is.list(x) && !is.environment(x)) {
--- End diff --
Seems the code only handle the special case of list here. What about an
environment? (As an environment is for a Map type )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
