Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/8884#issuecomment-149295691 Thanks. Merged into master. Please submit another PR to address the minor issues in the comment. We would like to see that when solver is `auto`, the `normal` solver will be picked up. This can be done by checking if the loss history is zero or not. Also, add another test case showing that when `n > 4096`, `l-bfgs will be picked up. Thanks.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org