Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/9154#discussion_r42534219
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -783,18 +783,6 @@ private[spark] class TaskSetManager(
/** Called by TaskScheduler when an executor is lost so we can
re-enqueue our tasks */
override def executorLost(execId: String, host: String, reason:
ExecutorLossReason) {
- logInfo("Re-queueing tasks for " + execId + " from TaskSet " +
taskSet.id)
-
- // Re-enqueue pending tasks for this host based on the status of the
cluster. Note
- // that it's okay if we add a task to the same queue twice (if it had
multiple preferred
- // locations), because dequeueTaskFromList will skip already-running
tasks.
- for (index <- getPendingTasksForExecutor(execId)) {
- addPendingTask(index, readding = true)
- }
- for (index <- getPendingTasksForHost(host)) {
- addPendingTask(index, readding = true)
- }
--- End diff --
Ah, now I see that @CodingCat had the same suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
