Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8840#discussion_r42577632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -128,30 +136,32 @@ private[sql] object PartitioningUtils { private[sql] def parsePartition( path: Path, defaultPartitionName: String, - typeInference: Boolean): Option[PartitionValues] = { + typeInference: Boolean): (Option[PartitionValues], Option[Path]) = { --- End diff -- Or change the `case class PartitionValues(columnNames: Seq[String], literals: Seq[Literal])` as `case class PartitionValues(path: String, columnNames: Seq[String], literals: Seq[Literal])`? Then the code probably much simple and readable.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org