Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/962#discussion_r14214424
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -39,6 +40,13 @@ private[spark] case class ByteBufferValues(buffer: 
ByteBuffer) extends BlockValu
     private[spark] case class IteratorValues(iterator: Iterator[Any]) extends 
BlockValues
     private[spark] case class ArrayBufferValues(buffer: ArrayBuffer[Any]) 
extends BlockValues
     
    +/* Class for returning a fetched block and associated metrics. */
    +private[spark] class BlockResult(val data: Iterator[Any], readMethod: 
DataReadMethod.Value,
    +    bytes: Long) {
    --- End diff --
    
    nit: case class? If not, format this like
    ```
    class BlockResult(
      data,
      readMethod,
      ...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to