GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/9192
[SPARK-10903] [SPARKR] R - Simplify SQLContext method signatures and use a
singleton
Eliminate the need to pass sqlContext to method since it is a singleton -
and we don't want to support multiple contexts in a R session.
Changes are done in a back compat way with deprecation warning added.
Method signature for S3 methods are added in a concise, clean approach such
that in the next release the deprecated signature can be taken out
easily/cleanly (just delete a few lines per method).
Custom method dispatch is implemented to allow for multiple JVM reference
types that are all 'jobj' in R and to avoid having to add 30 new exports.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rsqlcontext
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9192
----
commit 612f7f3613f881e164f76d0b937fb4787736d2ee
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-09T21:31:14Z
Refractor SQLContext and DataFrame functions to lookup sqlContext instance
in the env
commit efedce53a315d7ce23a53145e3de100d2a471690
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-20T06:31:44Z
Method dispatch to support omission of 'sqlContext' argument
commit fa50f789208e6a00c17b99c2deee8bbfbf091f4e
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-20T22:31:07Z
Improve route logic
commit fd3a835c2eea03d57b3ab6e5ae68f6497569e513
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-20T22:35:20Z
update tests
commit 8b3141a023e836e31be50bbb2d7f199711440015
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-21T01:01:38Z
Change to method dispatch
update more tests and add tests for back compat
commit d8e91f375ee7cc33ba77d67634aebbe201e9391f
Author: felixcheung <felixcheun...@hotmail.com>
Date: 2015-10-21T01:17:12Z
fix test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
