Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8026#issuecomment-149785524
@chenghao-intel, thanks a bunch for updating this; the current version of
this patch is a lot easier to understand and I'm happy with how clean the code
turned out. I left only minor style / clarity comments, which I don't mind
addressing myself on merge if you're too busy. If you don't mind, though, one
more round of quick updates to address my comments would be appreciated.
Anyhow, the technical changes here LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
